Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPLD Prime In IPFS: Target Merge Branch #7976

Merged
merged 85 commits into from
Aug 17, 2021
Merged

IPLD Prime In IPFS: Target Merge Branch #7976

merged 85 commits into from
Aug 17, 2021

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Mar 12, 2021 •
edited by aschmahmann
Loading

This feature branch updates a number of dependencies to directly make use of go-ipld-prime under the hood. The major exception is the unixfs subsystem, which remains the same via the go-ipld-legacy shim.

Before this branch is feature complete, a known / remaining sub-conversation that is ongoing is "How should we directly expose the newer ipld-prime node interface to programs making use of IPFS?". This conversation is occurring in #8046 which will merge into this branch when ready.

@hannahhoward hannahhoward mentioned this pull request Mar 12, 2021
Closed
hannahhoward and others added 8 commits March 25, 2021 17:34
@hannahhoward
feat(ipld): update to trusted store deps
127a354 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@mvdan
bump go-codec-dagpb version
91496b5 
This should fix a sharness test failure which we fixed by changing
PBNode decoding to allow any field order.
@hannahhoward
go-path integrated
52094b1
@hannahhoward
use basic resolver in gateway (provides unixfs adl)
e11af3a
@hannahhoward
resolve issues with error types from resolver
f5bfb04
@hannahhoward
feat(path): update to latest go-path
3f7626b 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
fix(deps): update to latest go-path
a56fbf3 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
fix(deps): fix unixfsnode imple
e3211c0 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@Stebalien Stebalien marked this pull request as draft April 13, 2021 22:21
@aschmahmann aschmahmann mentioned this pull request Apr 19, 2021
Closed
@hannahhoward
feat(node): add fetcher config top level dependency
5077fd3 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
fix(deps): update to latest go-path
63b6593 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
Merge pull request #8081 from ipfs/feat/fetcher-config-dependency
bae6c8a 
Add fetcher config top level dependency
@hannahhoward
Merge pull request #8028 from ipfs/feat/update-ipld-go-path
8d0ee3b 
go-path integrated
@hannahhoward
feat(coreapi): implement node interface
579c768 
implement a node interface that provides direct access to go-ipld-prime tools

License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
fix(deps): update deps to latest
fc26e27 
License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
fix(deps): update deps and fix syntax
7f716a1 
Update to latest fetcher/dag-writer and fix node api

License: MIT
Signed-off-by: hannahhoward <hannah@hannahhoward.net>
@hannahhoward
Merge pull request #8046 from ipfs/feat/node-api
98b792a 
Node API
@aschmahmann aschmahmann mentioned this pull request Aug 13, 2021
Merged
@BigLep
Copy link
Contributor

BigLep commented Aug 17, 2021 •
edited by aschmahmann
Loading

2021-08-17 update on outstanding items:

@aschmahmann: create issues for the following to fix during the release phase:

  1. Missing test for hang when doing dag get: 9339e82
  2. Bugs related to codecs that return EOF on encode/decode (EOF error are ignored by CLI so we would need to either fix that or wrap the errors)
    • echo "test" | ipfs dag put --input-enc=git-raw doesn't error or return a CID
    • echo "" | ipfs dag put --input-enc=dag-json --format=dag-json
  3. Bug where can only get raw bytes using the git codec but not round trip it. It should not do the first or also do the second.
❯ echo '{"foo" : 5}' | ipfs dag put --input-enc=raw
bafyreigg3nfoc7bnomgpdmziymlhhy3tgsistf2s36js2nwsfrumtjirba
🏠/workspace
❯ ipfs dag get --format=git-raw bafyreigg3nfoc7bnomgpdmziymlhhy3tgsistf2s36js2nwsfrumtjirba
{"foo" : 5}
🏠/workspace took 5s
❯ echo '{"foo" : 5}' | ipfs dag put --input-enc=git-raw
Error: unrecognized object type: {"foo"

aschmahmann
aschmahmann approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as this seems good enough for go-ipfs v0.10.0-rc1. There are a few outstanding issues linked above that we'll need to deal with before the final release.

Thanks everyone who helped push this over the finish line 🙇‍♂️, this was a huge and much needed endeavor to start upgrading our IPLD library usage.

@aschmahmann aschmahmann merged commit f63a997 into master Aug 17, 2021
@aschmahmann aschmahmann deleted the feat/ipld-in-ipfs branch August 17, 2021 17:32
@Stebalien Stebalien restored the feat/ipld-in-ipfs branch August 17, 2021 19:29
This was referenced Aug 23, 2021
Closed
Closed
@warpfork warpfork mentioned this pull request Aug 24, 2021
Open
@aschmahmann aschmahmann mentioned this pull request Sep 30, 2021
Closed
@aschmahmann aschmahmann mentioned this pull request Oct 18, 2021
Closed
@rvagg rvagg mentioned this pull request Dec 8, 2021
Closed
@liamsi liamsi mentioned this pull request Apr 11, 2022
Closed
2 tasks
@aschmahmann aschmahmann mentioned this pull request Aug 16, 2022
Closed
3 tasks
@hacdias hacdias deleted the feat/ipld-in-ipfs branch May 9, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warpfork warpfork warpfork left review comments

@rvagg rvagg rvagg left review comments

@willscott willscott willscott left review comments

@ribasushi ribasushi ribasushi left review comments

@Stebalien Stebalien Stebalien left review comments

@BigLep BigLep BigLep left review comments

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees

@warpfork warpfork

@aschmahmann aschmahmann

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
go-ipfs 0.10
Development

Successfully merging this pull request may close these issues.
9 participants
@hannahhoward @rvagg @willscott @warpfork @BigLep @Stebalien @ribasushi @aschmahmann @mvdan